Multiplayer fixes and Improvments #809
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the room name the user chooses persists across sessions in multiplayer mode
mikeage
reviewed
Jan 5, 2025
|
The body of the PR lists three things, but there's only one commit here... |
Revised percentage tracking to embed the progress directly into the ReliableKey, streamlining the process and simplifying debugging.
Multiplayer Manager to set the voice prefab as a child of the player prefab so that
Speaker prefab is now child of the head transform
…on/open-brush into multiplayer-fixes
sbanca
force-pushed
the
multiplayer-fixes
branch
from
18d7d17 to
83e8822
Compare
Spatialized max distance needs to be adjusted based on the `App.Scene.Pose.scale` to do so we introduce a new script `MultiplayerAudioSourcesManager` which set all of the remote users audioSources max distance whenever the scene scales up or down
Introduce a `RemotePlayer` class with `PlayerId`, `Nickname` and `ItransientData`, extendable with Role (e.g., observer/editor/owner) and VoiceStatus (e.g., muted/active speaker). Abstracts player details from the Photon SDK for better flexibility and clarity. Includes a list of `RemotePlayer` ready to be displayed and interacted with on a panel.
This Pop Up Window will enable the user to list the users, pass ownership, turn on and off users voice and edit user role
sbanca
force-pushed
the
multiplayer-fixes
branch
from
4c8b526 to
cd49bb8
Compare
fix missing collider
This shout the local audio source of the corresponding remote player
sbanca
force-pushed
the
multiplayer-fixes
branch
from
13020da to
61e17b4
Compare
sbanca
force-pushed
the
multiplayer-fixes
branch
from
61e17b4 to
e8547c9
Compare
removing redundant code and adding max player for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Improvements
In Room Controls: e8547c9
Colocation: Pick three points, e.g., three corners of a table.
Public Room Lists