Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplayer fixes and Improvments #809

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
2cadbf3
Make Room Name Persistent.
sbanca Jan 5, 2025
91b99b8
Fix sync percentage tracking
sbanca Jan 6, 2025
0f0e15b
Spatialized Sound
sbanca Jan 11, 2025
7e85eba
Merge branch 'main' into multiplayer-fixes
sbanca Jan 12, 2025
83a7cc1
Fix positioning of the Speaker Prefab
sbanca Jan 12, 2025
13de82b
Merge branch 'multiplayer-fixes' of https://github.com/icosa-foundati…
sbanca Jan 12, 2025
502d3cd
Enhancing the Aesthetics of Sync Progress
sbanca Jan 12, 2025
83e8822
Update HMD Font
sbanca Jan 14, 2025
ff0fc39
Adjust Spatialized Audio
sbanca Jan 15, 2025
8c674bf
Merge branch 'main' into multiplayer-fixes
sbanca Jan 17, 2025
a7879bb
Prepare Remote Player List for Display
sbanca Jan 18, 2025
cd49bb8
Adding Room Options Pop Up Window
sbanca Jan 18, 2025
6968607
Apply .gitattributes normalization
sbanca Jan 19, 2025
1fc6efb
Adding dynamic Player List to the PopUpWindow
sbanca Jan 19, 2025
6ceebe2
Update MultiplayerAudioSourcesManager.cs
sbanca Jan 20, 2025
91f3ab4
Update MultiplayerAudioSourcesManager.cs
sbanca Jan 20, 2025
24ac381
Nickname
sbanca Jan 20, 2025
ab58699
Update MultiplayerPanel.prefab
sbanca Jan 20, 2025
3c1bd2a
Mute Unmute -> turn off local audio source
sbanca Jan 20, 2025
973e6ef
Max Players setting add to Multiplayer Panel
sbanca Jan 25, 2025
e8547c9
Show hide room settings button
sbanca Jan 25, 2025
23313a7
Transfer Ownership RPC Method
sbanca Jan 26, 2025
9aa3142
Mute/Unmute -> Toggle
sbanca Jan 26, 2025
8ac62df
Toggle View mode only
sbanca Jan 26, 2025
781d0e1
Update MultiplayerManagerEditor.cs
sbanca Jan 26, 2025
53f6d4d
Kick users
sbanca Jan 26, 2025
cdb6355
Mute All and View Only All
sbanca Jan 26, 2025
cf7f4d8
Update MultiplayerPanel.prefab
sbanca Jan 26, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions Assets/Scripts/GUI/MultiplayerPanel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ public string RoomName
{
data.roomName = value;
UpdateDisplay();
SaveRoomName(value);
}
}

Expand Down Expand Up @@ -82,7 +83,7 @@ public void Awake()
{
data = new RoomCreateData
{
roomName = GenerateUniqueRoomName(),
roomName = "default room",
mikeage marked this conversation as resolved.
Show resolved Hide resolved
@private = false,
maxPlayers = 4,
voiceDisabled = false
Expand Down Expand Up @@ -111,13 +112,23 @@ private void OnLanguageChanged(Locale newLocale)
updateDisplay = true;
}

public async void RetrieveRoomName()
{
var storedRoomName = await m_multiplayer.GetAsync<string>("roomname");
RoomName = storedRoomName ?? GenerateUniqueRoomName();
}

private async void SaveRoomName(string roomName)
{
await m_multiplayer.StoreAsync("roomname", roomName);
}

public async void RetrieveUsername()
{
var storedNickname = await m_multiplayer.GetAsync<string>("nickname");
NickName = storedNickname ?? "Unnamed";
}


private async void SaveNickname(string nickname)
{
await m_multiplayer.StoreAsync("nickname", nickname);
Expand All @@ -129,6 +140,7 @@ protected override void OnEnablePanel()

m_multiplayer = new PlayerPrefsDataStore("Multiplayer");
RetrieveUsername();
RetrieveRoomName();

if (MultiplayerManager.m_Instance == null) return;
if (MultiplayerManager.m_Instance.State == ConnectionState.INITIALIZED || MultiplayerManager.m_Instance.State == ConnectionState.DISCONNECTED)
Expand Down
Loading