fix(analytics): check do not track #4329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
added
skip-changelog
julienrbrt
requested review from
ilgooz,
jeronimoalbi and
Pantani
as code owners
github-actions
bot
added
component:ci
Pantani
approved these changes
Aug 29, 2024
toschdev
approved these changes
Aug 29, 2024
mergify bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
Our do not track check was wrong and always returning true. This is why we were getting nothing. (cherry picked from commit e04d0f6)
Pantani
added a commit
that referenced
this pull request
Aug 29, 2024
Our do not track check was wrong and always returning true. This is why we were getting nothing. (cherry picked from commit e04d0f6) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Danilo Pantani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our do not track check was wrong and always returning true.
This is why we were getting nothing.