Remove clojars #81
Merged
Remove clojars #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvertdw
reviewed
Sep 18, 2024
| @@ -117,7 +117,6 @@ open class IHMCBuildExtension(val project: Project) | |||
| fun configureDependencyResolution() | |||
| { | |||
| declareMavenCentral() | |||
| repository("https://clojars.org/repo/") | |||
There was a problem hiding this comment.
How can you be sure this doesn't break anything for anybody? Is it that useful to remove?
There was a problem hiding this comment.
I would say we should be arguing why to keep it, not why to remove it. I don't see any reason anyone would be using it. Before I make any release of ihmc-build, I would double check that, at the very least, all of our repos resolve dependencies correctly and things are copesthetic.
There was a problem hiding this comment.
I guess it sketchy clojure libraries mostly, actually
calvertdw
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only thing I found which used something from the clojars repos was an unused ROS1 library for loading ROS bags. I've removed that dependency from ihmc-open-robotics-software and ensured nothing else used anything from clojars.