Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove clojars #81

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Remove clojars #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/main/kotlin/us/ihmc/build/IHMCBuildExtension.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ open class IHMCBuildExtension(val project: Project)
fun configureDependencyResolution()
{
declareMavenCentral()
repository("https://clojars.org/repo/")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can you be sure this doesn't break anything for anybody? Is it that useful to remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say we should be arguing why to keep it, not why to remove it. I don't see any reason anyone would be using it. Before I make any release of ihmc-build, I would double check that, at the very least, all of our repos resolve dependencies correctly and things are copesthetic.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it sketchy clojure libraries mostly, actually

repository("https://github.com/rosjava/rosjava_mvn_repo/raw/master")
repository("https://raw.githubusercontent.com/ihmcrobotics/maven-artifacts-archive/main/")
repository("https://jitpack.io")
Expand Down