Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build list of URLs simpler [refactor PR #179 for readability / maintainability] #180

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Build list of URLs simpler [refactor PR #179 for readability / maintainability] #180

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd3cbe7
Build list of URLs simpler
deldesir Jun 11, 2024
fbccaf2
Fix indentation
deldesir Jun 11, 2024
f087ff1
Update cps/tasks/metadata_extract.py
deldesir Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions cps/tasks/metadata_extract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,12 @@ def _fetch_requested_urls(self, conn):
if "error" in self.columns
else "SELECT path, duration FROM media WHERE path LIKE 'http%'")
rows = conn.execute(query).fetchall()
requested_urls = {row[0]: {"duration": row[1]} if row[1] is not None and row[1] > 0 else self.unavailable.append(row[0]) for row in rows}
for url in self.unavailable:
requested_urls.pop(url)
requested_urls = {}
for path, duration in rows:
if duration is not None and duration > 0:
requested_urls[path] = {"duration": duration};
else:
self.unavailable.append(path)
return requested_urls
except sqlite3.Error as db_error:
log.error("An error occurred while trying to connect to the database: %s", db_error)
Expand Down