Build list of URLs simpler [refactor PR #179 for readability / maintainability] #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holta
reviewed
Jun 11, 2024
Co-authored-by: A Holt <[email protected]>
|
Is this PR tested? (Please validate/confirm similar to original PR... !) |
|
Tested on Ubuntu 24.04 (LRN2)
|
holta
reviewed
Jun 11, 2024
| requested_urls = {} | ||
| for path, duration in rows: | ||
| if duration is not None and duration > 0: | ||
| requested_urls[path] = {"duration": duration}; |
There was a problem hiding this comment.
No, that was my mistake... I guess for doing too much C++
There was a problem hiding this comment.
No. I just removed it.
This was referenced Jun 11, 2024
holta
changed the title
holta
changed the title
holta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces list comprehension. Makes code simpler.