-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to simplify/generalize coupling #902
Conversation
doesn't seem to make a difference in the amount of communication
316a5d1
to
1e4cde0
Compare
causes missing communication errors in distributed lazy
5a5bcdb
to
5ff622a
Compare
@tulioricci, @MTCam I think this is ready for a look through. (I'll do the production merge after.) |
":func:`add_interface_boundaries` and include them when calling the " | ||
"individual operators instead.", DeprecationWarning, stacklevel=2) | ||
|
||
if not use_kappa_weighted_grad_flux_in_fluid: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we remove it right now and make the warning says that it is being ignored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 6cd4494.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is great. Only one slight concern from my perspective, but nothing preventing merge I think.
060bb66
to
6cd4494
Compare
Deprecates operator definitions in thermal coupling code and refocuses the API on setting up the interface boundaries. This allows for more flexibility on the driver side (e.g., more than 2 volumes, easier access to gradients, etc.).
cc @tulioricci
Questions for the review: