Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use mpi4py git version for full pkl5 feature set #972

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

matthiasdiener
Copy link
Member

@matthiasdiener matthiasdiener commented Sep 22, 2023

Needs illinois-ceesd/emirge#167

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@matthiasdiener matthiasdiener marked this pull request as ready for review September 27, 2023 20:39
@matthiasdiener matthiasdiener merged commit f8b4d86 into main Sep 27, 2023
13 checks passed
@matthiasdiener matthiasdiener deleted the mpi4py-git branch September 27, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants