-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite cmake files to simplify build system #309
Conversation
417c2f8
to
6ff5ab8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, but I don't understand the second commit. Were we padding the TLS segment of partition-alloc before? I don't think we should need to do this, because we don't pkey_mprotect
its thread locals as it isn't itself "in" any compartment. That said, I don't think I thought hard about the interaction of TLS usage in partition-alloc with our TLS scheme; I don't think I had really realized it was using TLS at all.
It does, though, for partition_alloc::(anonymous namespace)::g_disallow_allocations
, partition_alloc::internal::(anonymous namespace)::ReentrantScannerGuard::guard_
, partition_alloc::internal::g_thread_cache
, partition_alloc::internal::base::(anonymous namespace)::g_thread_id
, and partition_alloc::internal::base::(anonymous namespace)::g_is_main_thread
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with mostly minor nits. There's just one case we need to fix where the -include
flag is wrong and there's an issue with the partition alloc target that nginx tries to build.
@rinon I saw you effectively removed the |
I'm rebasing #300 on this PR so for now I'll leave |
2542815
to
a3d3028
Compare
c479da0
to
1ce7fba
Compare
1ce7fba
to
7b2f78b
Compare
LGTM. Could you update the target name for PartitionAlloc in docs/build_instructions.md? |
Replaces the define_test and define_shared_lib functions with a more generic and hopefully cleaner add_ia2_compartment function.
0d07c0f
to
6dab542
Compare
Replaces the
define_test
anddefine_shared_lib
functions with a more generic and hopefully cleaneradd_ia2_compartment
function.