Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Participant metrics #549

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Participant metrics #549

merged 5 commits into from
Apr 24, 2024

Conversation

jmfernandez
Copy link
Member

Added partial implementation for participant metrics page

Now it is possible to show a Markdown description in community entries,
and to show the events, datasets and tools in project entries.
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 15.00000% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 78.63%. Comparing base (997c536) to head (9cd0264).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #549       +/-   ##
===========================================
- Coverage   92.50%   78.63%   -13.87%     
===========================================
  Files          35       37        +2     
  Lines         280      337       +57     
  Branches       36       47       +11     
===========================================
+ Hits          259      265        +6     
- Misses         21       72       +51     
Files Coverage Δ
...nents/Communities/CommunityClassificationTable.vue 100.00% <ø> (ø)
pages/benchmarking/_community/_id/index.vue 87.50% <100.00%> (ø)
pages/benchmarking/_community/index.vue 93.93% <100.00%> (+0.18%) ⬆️
...ts/Challenges/ChallengeParticipantMetricsTable.vue 0.00% <0.00%> (ø)
pages/projects/_project/index.vue 66.66% <41.66%> (-20.00%) ⬇️
pages/benchmarking/_community/_id/participants.vue 0.00% <0.00%> (ø)

@carleshf
Copy link
Collaborator

All changes and additions seems to be fine. General comments:

  • Why the change on convention from _id to index? Because to be similar to react?
  • I like the change from acronym to challenge_label
  • Should the files _id.spec.js and _id.vue from the tools page be removed? Same for community?

Copy link
Collaborator

@carleshf carleshf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems correct

@carleshf
Copy link
Collaborator

I think that, even in codecov is failing (because of the downgrade of the score of -13.87%), the PR can be accepted.

@carleshf carleshf merged commit 1257f20 into master Apr 24, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants