Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of the observatory into the OEB web (Feature/observatory pages) #600

Closed
wants to merge 17 commits into from

Conversation

EvaMart
Copy link
Member

@EvaMart EvaMart commented May 30, 2024

Integration of the observatory into the OEB web.

Key potentially conflictive changes:

  • Nav bar: observatory has a drop down
  • Footer: footerMenu.js is used instead of menuEntries.js

required: (value) => !!value || 'Required.',
gitHubURL: (value) => {
const pattern =
/^(http(s?):\/\/)?(www\.)?github\.([a-z])+\/(.*)+\/(.*)+\/?$/i;

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with 'github.a/' and containing many repetitions of 'a'.
required: (value) => !!value || 'Required.',
gitHubURL: (value) => {
const pattern =
/^(http(s?):\/\/)?(www\.)?github\.([a-z])+\/(.*)+\/(.*)+\/?$/i;

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with 'github.a//' and containing many repetitions of 'a'.
required: (value) => !!value || 'Required.',
gitHubURL: (value) => {
const pattern =
/^(http(s?):\/\/)?(www\.)?github\.([a-z])+\/(.*)+\/(.*)+\/?$/i;

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with 'github.a/' and containing many repetitions of 'a'.
required: (value) => !!value || 'Required.',
gitHubURL: (value) => {
const pattern =
/^(http(s?):\/\/)?(www\.)?github\.([a-z])+\/(.*)+\/(.*)+\/?$/i;

Check failure

Code scanning / CodeQL

Inefficient regular expression High

This part of the regular expression may cause exponential backtracking on strings starting with 'github.a//' and containing many repetitions of 'a'.
@EvaMart EvaMart closed this May 30, 2024
@EvaMart EvaMart deleted the feature/observatory-pages branch May 31, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant