Implement CupyArrayContext #251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasdiener
force-pushed
the
cupyactx
branch
4 times, most recently
from
ce508df to
55b4cbf
Compare
Co-authored-by: Kaushik Kulkarni <[email protected]>
matthiasdiener
force-pushed
the
cupyactx
branch
from
55b4cbf to
7ab5211
Compare
8 tasks
matthiasdiener
commented
Sep 6, 2024
test/test_arraycontext.py
Outdated
Comment on lines
1254
to
1256
| if isinstance(actx, CupyArrayContext): | ||
| pytest.skip("CupyArrayContext does not support object arrays") | ||
|
|
There was a problem hiding this comment.
@inducer: We had briefly discussed adding support for object arrays via a wrapper (?), but I'm not sure how that should look like.
matthiasdiener
commented
Sep 6, 2024
Comment on lines
+242
to
+244
| d = cupy.cuda.runtime.getDeviceProperties(cupy.cuda.Device()) | ||
| name = d["name"].decode("utf-8") | ||
| return f"<CupyArrayContext> on {cupy.cuda.Device()}:{name}" |
There was a problem hiding this comment.
This is the only part of the code that give me pause for supporting something like cupy-rocm.
There was a problem hiding this comment.
cupy-rocm seems to be completely out-of-date, so probably no big deal.
|
This is ready for a first look @inducer |
matthiasdiener
force-pushed
the
cupyactx
branch
from
256dbdb to
5f4c4d9
Compare
matthiasdiener
force-pushed
the
cupyactx
branch
from
e9c42dd to
8fd5488
Compare
|
This is ready for review @inducer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please squash