Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CupyArrayContext #251
base: main
Are you sure you want to change the base?
Implement CupyArrayContext #251
Changes from all commits
7ab5211
96b7a3d
8dee38d
2c025eb
d6e3136
bfa648a
27e5a19
6d507e1
8fb4e0b
be70b67
677419b
6250211
d61f0cf
5871ae7
9c56443
fd95813
5f4c4d9
a8fe272
2296c6d
8fd5488
6f3cd94
ab8266d
79b0bc3
70aff99
8b5c6cf
8561b2f
904e061
340f9dc
3ee28cc
ce33f23
cd2a366
8e7e1f1
326e164
4d429f8
69e2133
f83ee9c
fae85a4
d9ce8d5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that CI for this is not running on Github (and cannot run). Why install the package then? (Also above.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If cupy is not installed, these tests will fail, e.g. mypy with
arraycontext/impl/cupy/__init__.py:57: error: Cannot find implementation or library stub for module named "cupy" [import-not-found]
. We couldtype: ignore
these, but at least in the case of pylint we would have to annotate everyimport cupy
line with# pylint: disable=import-error
. Not sure which way is better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you adapt
.gitlab-ci.yml
and push a branch to Gitlab to show that CI for the actx succeeds? I've added you to the project there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 79b0bc3 et al., and seems to work: https://gitlab.tiker.net/inducer/arraycontext/-/jobs/804938
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, what are the implementations for debugging/profiling? (also mentioned in
doc/
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there are any at the moment (?). Unless passing a
CommandQueue
with profiling enabled counts there..It would be nice to have some fancier profiling for things though 😁