fix: no focus after display horizontal paging page content #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pspaczek
commented
Jan 10, 2024
| @@ -226,6 +226,7 @@ const menuItems = computed<MenuItemAttrsProps[]>(() => itemsAsArray.value.map((i | |||
| item, | |||
| ]; | |||
| }, | |||
| tabindex: isActive.value ? '-1' : null, | |||
There was a problem hiding this comment.
@AlanLes I have one TS error; Can you help me and know how to fix it?
There was a problem hiding this comment.
Hello, sure what's the error? :)
kkk, I'm on it :)
AlanLes
reviewed
Jan 11, 2024
| @@ -226,6 +226,7 @@ const menuItems = computed<MenuItemAttrsProps[]>(() => itemsAsArray.value.map((i | |||
| item, | |||
| ]; | |||
| }, | |||
| tabindex: isActive.value ? '-1' : null, | |||
There was a problem hiding this comment.
It does the job :)
Suggested change
| tabindex: isActive.value ? '-1' : null, | |
| tabindex: isActive.value ? '-1' : undefined, |
tabindex doesn't seem to accept the null value :)
but I'm not sure if it wouldn't be better to implicitly not set the tabindex property at all... instead of setting it to undefined.
It could be done with this line instead:
Suggested change
| tabindex: isActive.value ? '-1' : null, | |
| ...(isActive.value ? { tabindex: '-1' } : {}), |
pspaczek
changed the title
pspaczek
added a commit
that referenced
this pull request
Jan 15, 2024
* fix: no focus after open new page * feat: focus menu button on back * fix(ts): tabindex in menuItems * fix: use nextTick to prevent to fast focusing * fix(ts): solve TS18047 and TS2464 errors * fix(ts): solve TS7053 error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New focus functionality in this PR.