-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: no focus after display horizontal paging page content #330
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
99eabc1
fix: no focus after open new page
pspaczek 58d9f78
feat: focus menu button on back
pspaczek 10d82ac
Merge branch 'develop' into fix/#329
pspaczek 7974fee
fix(ts): tabindex in menuItems
pspaczek c8537ad
fix: use nextTick to prevent to fast focusing
pspaczek 0db4506
fix(ts): solve TS18047 and TS2464 errors
pspaczek 4837959
fix(ts): solve TS7053 error
pspaczek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -1,7 +1,7 @@ | ||||||||||
<template> | ||||||||||
<div | ||||||||||
:class="[ | ||||||||||
'ui-horizontal-paging', { 'ui-horizontal-paging--nested': isNested } | ||||||||||
'ui-horizontal-paging', { 'ui-horizontal-paging--nested': isNested }, | ||||||||||
]" | ||||||||||
> | ||||||||||
<!-- @slot Use this slot to replace header template. --> | ||||||||||
|
@@ -37,7 +37,7 @@ | |||||||||
name="title" | ||||||||||
v-bind="{ | ||||||||||
headingTitleAttrs, | ||||||||||
title: currentTitle | ||||||||||
title: currentTitle, | ||||||||||
}" | ||||||||||
> | ||||||||||
<UiHeading v-bind="headingTitleAttrs"> | ||||||||||
|
@@ -49,7 +49,7 @@ | |||||||||
<div class="ui-horizontal-paging__wrapper"> | ||||||||||
<div | ||||||||||
:class="[ | ||||||||||
'ui-horizontal-paging__section', { 'ui-horizontal-paging__section--is-active': isActive } | ||||||||||
'ui-horizontal-paging__section', { 'ui-horizontal-paging__section--is-active': isActive }, | ||||||||||
]" | ||||||||||
> | ||||||||||
<!-- @slot Use this slot to replace menu template. --> | ||||||||||
|
@@ -208,7 +208,7 @@ | |||||||||
const handleBackClick = () => { | ||||||||||
activeItems.value = activeItems.value.slice(0, -1); | ||||||||||
}; | ||||||||||
const menuItems = computed<MenuItemAttrsProps[]>(() => itemsAsArray.value.map((item) => { | ||||||||||
/* eslint-disable @typescript-eslint/no-unused-vars */ | ||||||||||
const { | ||||||||||
title, | ||||||||||
|
@@ -226,6 +226,7 @@ | |||||||||
item, | ||||||||||
]; | ||||||||||
}, | ||||||||||
tabindex: isActive.value ? '-1' : null, | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It does the job :)
Suggested change
tabindex doesn't seem to accept the but I'm not sure if it wouldn't be better to implicitly not set the
Suggested change
|
||||||||||
...rest, | ||||||||||
}; | ||||||||||
})); | ||||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlanLes I have one TS error; Can you help me and know how to fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, sure what's the error? :)kkk, I'm on it :)