Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent regressions when upgrading pdfjs-dist #937

Merged
merged 19 commits into from
May 14, 2024

Conversation

make-github-pseudonymous-again
Copy link
Contributor

Fixes #683.

@make-github-pseudonymous-again make-github-pseudonymous-again added feature/attachments This issue is about the attachments functionality deps This issue has to do with dependencies dx This is about developer experience labels May 11, 2024
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 92.75362% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 65.85%. Comparing base (ea92e65) to head (02e9cba).

Files Patch % Lines
imports/lib/blob/blobToDataURL.ts 80.00% 3 Missing and 1 partial ⚠️
imports/lib/blob/blobToImage.ts 75.00% 3 Missing ⚠️
imports/lib/pdf/pdfthumbnails.ts 62.50% 0 Missing and 3 partials ⚠️
server/polyfill/fetch.ts 62.50% 1 Missing and 2 partials ⚠️
imports/_test/fixtures.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
+ Coverage   64.46%   65.85%   +1.39%     
==========================================
  Files         703      715      +12     
  Lines        9705     9893     +188     
  Branches     1335     1346      +11     
==========================================
+ Hits         6256     6515     +259     
+ Misses       3003     2919      -84     
- Partials      446      459      +13     
Flag Coverage Δ
test 72.10% <91.78%> (+2.33%) ⬆️
test-app 53.70% <41.86%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@make-github-pseudonymous-again make-github-pseudonymous-again marked this pull request as ready for review May 14, 2024 00:22
@make-github-pseudonymous-again make-github-pseudonymous-again added technology/pdf This has to do with leveraging the portable document format. technology/png This has to do with leveraging the portable network graphics format. technology/sharp This has to do with leveraging the sharp image manipulation library. labels May 14, 2024
Merged via the queue into main with commit 3b8b729 May 14, 2024
22 checks passed
@make-github-pseudonymous-again make-github-pseudonymous-again deleted the test-pdfjs-dist-1 branch May 20, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps This issue has to do with dependencies dx This is about developer experience feature/attachments This issue is about the attachments functionality technology/pdf This has to do with leveraging the portable document format. technology/png This has to do with leveraging the portable network graphics format. technology/sharp This has to do with leveraging the sharp image manipulation library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a test that fails when pdfjs-dist is incompatible with Meteor
1 participant