Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec/keeper: Adds Skip threshold and threshold emission tracking #30

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

angbrav
Copy link
Contributor

@angbrav angbrav commented Oct 27, 2023

The vote bookkeeper now emits a skip threshold when f+1 for any value in a given round is reached. This PR also adds logic to avoid emitting the same threshold multiple times (only emitted the first time the quorum is reached).

Emission logic:

  • After applying a vote, the keeper always returns an event.
  • Each event is emitted once, except for "None" which can be emitted an unbounded number of times.
  • The keeper emits a Skip event only if no quorum event has been previously emitted for that round.

@angbrav angbrav marked this pull request as draft October 27, 2023 16:18
@adizere adizere changed the title Adds Skip threshold and threshold emission tracking spec/keeper: Adds Skip threshold and threshold emission tracking Oct 28, 2023
Copy link
Member

@josef-widder josef-widder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks

@angbrav angbrav marked this pull request as ready for review October 31, 2023 19:06
@romac romac mentioned this pull request Nov 2, 2023
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and was very helpful when working on #39

@angbrav angbrav merged commit c5b7d1c into main Nov 3, 2023
1 check passed
@angbrav angbrav deleted the manuel/f+1-rule branch November 3, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants