vote: Complete vote keeper #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
force-pushed
the
romac/complete-vote-keeper
branch
from
08d3ae9 to
1a551d6
Compare
Codecov Report
@@ Coverage Diff @@
## romac/rust-state-machine #39 +/- ##
============================================================
- Coverage 86.21% 84.26% -1.95%
============================================================
Files 20 23 +3
Lines 1037 1220 +183
============================================================
+ Hits 894 1028 +134
- Misses 143 192 +49
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
7 tasks
romac
added a commit
that referenced
this pull request
Nov 8, 2023
* Rename `Threshold::Init` to `Unreached` * WIP: Pass votes directly to `VoteCount` * Cleanup * Split `compute_threshold` out of `add_vote` * Only count a single vote per validator address * Emit `PrecommitAny` message when we reach `Nil` threshold for precommits * Doc comment * Refactor `VoteCount` implementation * Fix tests * Split `vote` crate into more modules * Add Skip threshold * Refactor data kept by the `VoteKeeper` per-round * Move dealing with skip threshold into `VoteKeeper` * Rename `Event::RoundSkip` to `Event::SkipRound` * Cleanup * Include number of round to skip to in `SkipRound` message * Parametrize over thresholds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #25
Based on the spec at #30 and the ADR at #32