feat(quint): refactor the blocksync spec. #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* quint: fix test unit with new driver's methods * quint: fix test units with new decision type * quint: test-all.sh script with optional params
cason
commented
Nov 8, 2024
cason
commented
Nov 8, 2024
There was a problem hiding this comment.
Fast and can be tested in isolation.
cason
commented
Nov 8, 2024
|
The author of this PR, cason, is not an activated member of this organization on Codecov. |
Co-authored-by: Josef Widder <[email protected]>
|
There were some open points in #462 that we should fix here. |
* Start Blocksync * new Height enabled. needs to be tested * blocksync fuctions done * it is moving * Daniel told me to push * syncing on the lucky path * syncing * moved definitions a bit around * code cleanup * more cleanup * polishing * fix(quint): fix test units with new driver's methods and types (#524) * quint: fix test unit with new driver's methods * quint: fix test units with new decision type * quint: test-all.sh script with optional params * Apply suggestions from code review Co-authored-by: Josef Widder <[email protected]> --------- Co-authored-by: Daniel <[email protected]>
cason
force-pushed
the
cason/462-blocksync
branch
from
28c45d7 to
d03d5fd
Compare
cason
commented
Nov 11, 2024
specs/quint/specs/sync.qnt
Outdated
There was a problem hiding this comment.
Replaced by blocksync directory.
7 tasks
josef-widder
approved these changes
Nov 15, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #559.
Follow-up from #462
PR author checklist