-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for adding property brand name
to OMO
#148
Comments
brand name
to OMO
I like the idea, with a couple comments: (2) Maybe there is something different between "aspirin", "paracetamol" etc and the drug brand name from the manufacturer? For example Tylenol or Panadol for the latter (in addition to aspirin examples above) Based on your proposed definition of the property would it be fair to say "aspirin" and "paracetamol" are synonyms, while "Aspirin" (where trademarked), "Zorprin", "Tylenol" etc are brand names? |
that's a good point. I would lean on having a country-agnostic definition for this high-level term, as at this point I don't think the information about country specificity is available in ChEBI (I think it just slices by language, and not country) I wonder if this also means we should be grouping this under "layperson synonym" and not the top-level synonym type |
Not doing country specific for the generic property sounds good to me. I like the idea of 'layperson synonym' but the label bothers me, e.g. paracetamol/acetaminophen is really the name used by pharmacists etcs, see https://en.wikipedia.org/wiki/Paracetamol#Naming. What about something similar to https://en.wikipedia.org/wiki/International_nonproprietary_name? I think that may be what we are looking for here. |
That's a really interesting link that could lead to a whole swath of other requests here. I also see your point about it not being aligned well with "layperson synonym" INN is also used as a different ChEBI synonym, so I think that is definitely the top of the list. But I would be interested to add the Austrailian Approved Name, British Approved name, United States Adopted Name, Japanese Accepted name, etc. to give additional context when desired. |
No need to assign me; maybe share the issue once in the ontology metadata channel, for greater visibility, and if you don't hear anything negative in 72 hours, just make a PR. I have no larger concerns, other than the fact that the border between "synonym" and other kinds of relations are becoming pretty fuzzy here. I am not sure how many clinicians would consider the brand name a synonym of the generic name or even the chemical name, they are pretty different things, at least I thought so. But lets get some others to weigh in, maybe even someone from Chebi and PRO (@nataled).
WARNING TABLE IS SUBJECT TO HALLUCINATION (ChatGPT) |
Sorry if this is too pure, but it says for example here that synonyms are supposed to be reflexive. (We can presume that gets modified to the extent a synonym is only close or related, as opposed to an exact synonym. But the concept still applies IMHO.) I'm not seeing how Advil someSynonym ibuprofen is reflexive. One is clearly a subset of the other, and they have different characteristics and semantic applications. (All Advils are ibuprofen, but not all ibuprofens are Advils. The day that an Advil has an unfortunate manufacturing defect that ibuprofen is not suppose to have, considering them a synonym will be clearly a bad idea. What am I missing? |
Some issues:
|
Closes information-artifact-ontology#148, noting caveats brought up by @hoganwr in information-artifact-ontology#148 (comment).
IRI
No response
Label
brand name
Definition of the property
A synonym that corresponds to a brand name, e.g., used when a drug is sold at a pharmacy
Parent property
http://www.geneontology.org/formats/oboInOwl#SynonymType
What is the range of the property in question?
xsd:string
Examples of use
The brand name for CHEBI:15365 (acetylsalicylic acid) is "aspirin"
Motivation to add
ChEBI currently uses a hash URI http://purl.obolibrary.org/obo/chebi#BRAND_NAME, I would like to standardize this in OMO
ORCID, ROR or Wikidata identifier of the contributor
https://orcid.org/0000-0003-4423-4370
OMO Checklist
The text was updated successfully, but these errors were encountered: