Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for adding property brand name to OMO #148

Open
2 tasks done
cthoyt opened this issue Sep 29, 2023 · 7 comments · May be fixed by #162
Open
2 tasks done

Request for adding property brand name to OMO #148

cthoyt opened this issue Sep 29, 2023 · 7 comments · May be fixed by #162
Assignees

Comments

@cthoyt
Copy link
Contributor

cthoyt commented Sep 29, 2023

IRI

No response

Label

brand name

Definition of the property

A synonym that corresponds to a brand name, e.g., used when a drug is sold at a pharmacy

Parent property

http://www.geneontology.org/formats/oboInOwl#SynonymType

What is the range of the property in question?

xsd:string

Examples of use

The brand name for CHEBI:15365 (acetylsalicylic acid) is "aspirin"

Motivation to add

ChEBI currently uses a hash URI http://purl.obolibrary.org/obo/chebi#BRAND_NAME, I would like to standardize this in OMO

ORCID, ROR or Wikidata identifier of the contributor

https://orcid.org/0000-0003-4423-4370

OMO Checklist

  • I believe the property is generally useful beyond my specific ontology needs.
  • There is no other property in OMO that covers the same use case.
@cthoyt cthoyt changed the title Request for adding property [NAME] to OMO Request for adding property brand name to OMO Sep 29, 2023
@mcourtot
Copy link
Contributor

I like the idea, with a couple comments:
(1) this will be country dependant. Not sure whether CHEBI considers this, but the same molecule will have different names, brand names etc across countries.
For example aspirin is a generic name in the USA, while it is trademarked in Canada.
https://www.rxlist.com/aspirin/generic-drug.htm shows that "Aspirin is available under the following different brand names: Zorprin, Bayer Buffered Aspirin "

(2) Maybe there is something different between "aspirin", "paracetamol" etc and the drug brand name from the manufacturer? For example Tylenol or Panadol for the latter (in addition to aspirin examples above) Based on your proposed definition of the property would it be fair to say "aspirin" and "paracetamol" are synonyms, while "Aspirin" (where trademarked), "Zorprin", "Tylenol" etc are brand names?

@cthoyt
Copy link
Contributor Author

cthoyt commented Sep 29, 2023

that's a good point. I would lean on having a country-agnostic definition for this high-level term, as at this point I don't think the information about country specificity is available in ChEBI (I think it just slices by language, and not country)

I wonder if this also means we should be grouping this under "layperson synonym" and not the top-level synonym type

@mcourtot
Copy link
Contributor

Not doing country specific for the generic property sounds good to me.

I like the idea of 'layperson synonym' but the label bothers me, e.g. paracetamol/acetaminophen is really the name used by pharmacists etcs, see https://en.wikipedia.org/wiki/Paracetamol#Naming.

What about something similar to https://en.wikipedia.org/wiki/International_nonproprietary_name? I think that may be what we are looking for here.

@cthoyt
Copy link
Contributor Author

cthoyt commented Sep 29, 2023

I like the idea of 'layperson synonym' but the label bothers me, e.g. paracetamol/acetaminophen is really the name used by pharmacists etcs, see https://en.wikipedia.org/wiki/Paracetamol#Naming.

That's a really interesting link that could lead to a whole swath of other requests here. I also see your point about it not being aligned well with "layperson synonym"

INN is also used as a different ChEBI synonym, so I think that is definitely the top of the list. But I would be interested to add the Austrailian Approved Name, British Approved name, United States Adopted Name, Japanese Accepted name, etc. to give additional context when desired.

@matentzn
Copy link
Contributor

matentzn commented Sep 29, 2023

No need to assign me; maybe share the issue once in the ontology metadata channel, for greater visibility, and if you don't hear anything negative in 72 hours, just make a PR. I have no larger concerns, other than the fact that the border between "synonym" and other kinds of relations are becoming pretty fuzzy here.

I am not sure how many clinicians would consider the brand name a synonym of the generic name or even the chemical name, they are pretty different things, at least I thought so. But lets get some others to weigh in, maybe even someone from Chebi and PRO (@nataled).

Brand Name Generic Name Chemical Name
Tylenol Acetaminophen (US) N-(4-hydroxyphenyl)ethanamide
Paracetamol (UK)
Advil Ibuprofen (RS)-2-(4-(2-methylpropyl)phenyl)propanoic acid
Prozac Fluoxetine N-methyl-3-phenyl-3-[4-(trifluoromethyl)phenoxy]propan-1-amine
Lipitor Atorvastatin (3R,5R)-7-[2-(4-fluorophenyl)-3-phenyl-4-(phenylcarbamoyl)-5-propan-2-ylpyrrol-1-yl]-3,5-dihydroxyheptanoic acid

WARNING TABLE IS SUBJECT TO HALLUCINATION (ChatGPT)

@graybeal
Copy link

Sorry if this is too pure, but it says for example here that synonyms are supposed to be reflexive. (We can presume that gets modified to the extent a synonym is only close or related, as opposed to an exact synonym. But the concept still applies IMHO.)

I'm not seeing how Advil someSynonym ibuprofen is reflexive. One is clearly a subset of the other, and they have different characteristics and semantic applications. (All Advils are ibuprofen, but not all ibuprofens are Advils. The day that an Advil has an unfortunate manufacturing defect that ibuprofen is not suppose to have, considering them a synonym will be clearly a bad idea.

What am I missing?

@hoganwr
Copy link

hoganwr commented Oct 3, 2023

Some issues:

  1. Neither paracetamol nor acetaminophen is a brand name. I just want to clarify that because it seems like that issue is being confused with brand name
  2. The different brand names issues is an important one. Minimally, brand will differ across countries, but they vary even within a country
  3. I've seen in the past where everyone admixture of active ingredients that contains acetaminophen is conferred as a "brand name" on acetaminophen. For example 'Vicodin'. Well, 'Vicodin' is NOT NOT NOT NOT NOT NOT a brand name of acetaminophen. It is quite specifically and definitively a brand name of a combination of hydrocodone and acetaminophen. That for sure would blow apart any sense of reflexiveness. The same issue exists in spades with all the crazy cold/cough formulations that involve acetaminophen. 'Dayquil' is also NOT a brand name of 'acetaminophen'

cthoyt added a commit to cthoyt/ontology-metadata that referenced this issue Nov 21, 2023
@cthoyt cthoyt linked a pull request Nov 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants