Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add synonym column to annotation property template #156

Merged

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Oct 23, 2023

Closes #155

This PR adds a new column to the annotation properties template TSV such that synonyms can be added to synonym type labels (because yo dawg, I heard you like synonyms)

It demonstrates by adding INN as an exact synonym of International Nonproproprietary Name.

CC @matentzn I am not sure how to test updates to this file myself, nor where to look for such documentation

Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so you get this out of the way: do you want to add narrow and broad synonym columns as well?

@cthoyt
Copy link
Contributor Author

cthoyt commented Oct 23, 2023

@matentzn I don't think so, we still need to have a discussion about the acronyms and also potentially hierarchical synonym types (#151) before we might need those

Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Thank you!

@matentzn matentzn merged commit 46dd211 into information-artifact-ontology:master Oct 24, 2023
1 check passed
@cthoyt cthoyt deleted the template-synonyms branch October 24, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to add synonyms to synonym types?
2 participants