Update knowledge-submissions-past-wikipedia.md #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjasghar
force-pushed
the
lhawthorn-patch-5
branch
2 times, most recently
from
4824ae3 to
731161e
Compare
|
I helped out yoru linting issues, the spell check doesn't like a bunch of the words...i guess we'll need to add them to the spell checker now: |
jjasghar
added a commit
to jjasghar/dev-docs
that referenced
this pull request
Jun 26, 2024
PR instructlab#105 needs some new words added to the spelling dictionary. Signed-off-by: JJ Asghar <[email protected]>
markstur
reviewed
Jun 26, 2024
markstur
reviewed
Jun 26, 2024
jjasghar
force-pushed
the
lhawthorn-patch-5
branch
from
731161e to
68b81b2
Compare
jjasghar
added a commit
to jjasghar/dev-docs
that referenced
this pull request
Jun 26, 2024
PR instructlab#105 needs some new words added to the spelling dictionary. Signed-off-by: JJ Asghar <[email protected]>
nathan-weinberg
added a commit
that referenced
this pull request
Jun 27, 2024
Update spelling per #105
|
@Mergifyio rebase |
❌ Unable to rebase: user
|
|
LH is unaware of the existence of a Mergify dashboard and will get educated when maintainer team is online. (Edit: Oh wait I found it in handy dev doc) |
|
@Mergifyio rebase |
Added new approved Knowledge submission data sources, updated status for several. Updated documentation with new process to take in requested knowledge sources to be open a PR against this devdoc. Related to issue #59 which should be closed once this PR is reviewed and merged. Co-Authored-by: JJ Asghar <[email protected]> Signed-off-by: Leslie Hawthorn <[email protected]>
✅ Branch has been successfully rebased |
lhawthorn
force-pushed
the
lhawthorn-patch-5
branch
from
68b81b2 to
3bfba80
Compare
bjhargrave
requested changes
Jul 1, 2024
nathan-weinberg
approved these changes
Jul 1, 2024
hickeyma
added a commit
to hickeyma/dev-docs
that referenced
this pull request
Jul 2, 2024
Review comments in: instructlab#105 (review) Signed-off-by: Martin Hickey <[email protected]> Co-authored-by: Leslie Hawthorn <[email protected]>
|
@hickeyma Your fix commit is not pushed to this PR. It is just in your fork. |
hickeyma
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
LGTM thanks @lhawthorn for the update of the updates.
@bjhargrave Added your suggestions. Do you mind doing a quick review?
|
Shoot, I see that @bjhargrave. Let me try and fix that. |
Review comments: #105 (review) Signed-off-by: Martin Hickey <[email protected]> Co-authored-by: Leslie Hawthorn <[email protected]>
|
Thanks @bjhargrave for the help with the initial commit issue. Ready for review now. |
bjhargrave
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new approved Knowledge submission data sources, updated status for several.
Updated documentation with new process to take in requested knowledge sources to be open a PR against this devdoc.
Related to issue #59 which should be closed once this PR is reviewed and merged.
Closes #59