[MatmulLoopPipeline]: Prefetch 2D loads #4051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiotto, Ettore <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a safeguard to ensure that only 2D tensor load operations are prefetched in the MatmulLoopPipeline, preventing generation of invalid prefetch operations that could lead to assertions or incorrect code generation.
- Updated comments to clarify caching behavior.
- Added a check to skip prefetching for non-2D tensor loads.
third_party/intel/lib/TritonIntelGPUTransforms/Pipeliner/MatmulLoopPipeline.cpp
Show resolved
Hide resolved
etiotto
commented
Apr 29, 2025
third_party/intel/lib/TritonIntelGPUTransforms/Pipeliner/MatmulLoopPipeline.cpp
Show resolved
Hide resolved
whitneywhtsang
approved these changes
Apr 29, 2025
alexbaden
reviewed
Apr 29, 2025
Signed-off-by: Tiotto, Ettore <[email protected]>
chengjunlu
approved these changes
Apr 30, 2025
I have added a new lit test. I discovered the problem while working on another PR (#3634) which was failing one of the CI tests.. |
david-hls
pushed a commit
to david-hls/intel-xpu-backend-for-triton
that referenced
this pull request
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check to prefetch only 2D tensor loads loads. This avoid potential generation of invalid prefetch operations which would cause assertions in subsequent passes or lead to incorrect code generation.