Store transpose attribute in Subgroup2DBlockIO layouts #4549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the primary goals of the Subgroup 2D Block IO encoding is to be able to convert to an accurate Linear Layout representation for data produced by Subgroup 2D Block IO instructions. To do this, we need to store transpose information in the layout as an attribute. The attribute tells us to swap the order of the height/width parameters in the layout definition when building the linear layout representation, in effect performing the post-load transpose in registers (this is consistent with the SPV intrinsic documentation, https://github.khronos.org/SPIRV-Registry/extensions/INTEL/SPV_INTEL_2d_block_io. The end result is we get a layout corresponding to the post-transpose loaded data in registers:
depends on #4500 / #4463