Skip to content

[SYCL][NFC] Return adapter by ref in KernelProgramCache #19186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 1, 2025
Merged

[SYCL][NFC] Return adapter by ref in KernelProgramCache #19186

merged 3 commits into from
Jul 1, 2025

Conversation

uditagarwal97
Copy link
Contributor

No description provided.

@uditagarwal97 uditagarwal97 self-assigned this Jun 27, 2025
@uditagarwal97 uditagarwal97 force-pushed the private/udit/adapter_refac1 branch from 88578bb to 58a17e9 Compare June 27, 2025 14:19
@uditagarwal97 uditagarwal97 marked this pull request as ready for review June 27, 2025 14:19
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner June 27, 2025 14:19
@uditagarwal97 uditagarwal97 mentioned this pull request Jun 27, 2025
Merged
aelovikov-intel
aelovikov-intel reviewed Jun 27, 2025
View reviewed changes
uditagarwal97
uditagarwal97 commented Jun 27, 2025
View reviewed changes
aelovikov-intel
aelovikov-intel reviewed Jun 27, 2025
View reviewed changes
sycl/source/detail/kernel_program_cache.hpp Outdated
Val = nullptr;
}
ProgramBuildResult(const AdapterPtr &AAdapter, BuildState InitialState)
ProgramBuildResult(const adapter_impl &AAdapter, BuildState InitialState)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still AAdapter.

uditagarwal97
uditagarwal97 commented Jun 27, 2025
View reviewed changes
@uditagarwal97 uditagarwal97 mentioned this pull request Jun 27, 2025
Open
uditagarwal97 added a commit that referenced this pull request Jul 1, 2025
@uditagarwal97
[SYCL][NFC] Pass adapter by reference in backend[_impl] (#19187)
b747578 
It's a part of larger refactoring effort to pass adapter via reference
instead of pointer everywhere in the codebase.

Follow-up of:
#19186
#19184
@uditagarwal97
Copy link
Contributor Author

Win BMG failure:

********************
Failed Tests (3):
  SYCL :: Adapters/level_zero/ext_intel_cslice.cpp
  SYCL :: Adapters/level_zero/ext_intel_queue_index.cpp
  SYCL :: Adapters/sycl-ls-uuid-subdevs.cpp

********************
Unexpectedly Passed Tests (5):
  SYCL :: bindless_images/array/fetch_handle_carray2d.cpp
  SYCL :: bindless_images/read_1D_O0.cpp
  SYCL :: bindless_images/sampled_fetch/fetch_1D_O0.cpp
  SYCL :: bindless_images/sampled_fetch/fetch_2D_O0.cpp
  SYCL :: bindless_images/sampling_1D_O0.cpp


Testing Time: 181.39s

Total Discovered Tests: 2431
  Unsupported        : 1147 (47.18%)
  Passed             : 1265 (52.04%)
  Expectedly Failed  :   11 (0.45%)
  Failed             :    3 (0.12%)
  Unexpectedly Passed:    5 (0.21%)

Adapter tests were marked XFAIL in #19242 and Bindless images tests were fixed in #19215. All of these test failures are unrelated to this PR. Merging.

@uditagarwal97 uditagarwal97 merged commit 50212fd into sycl Jul 1, 2025
39 of 43 checks passed
@uditagarwal97 uditagarwal97 deleted the private/udit/adapter_refac1 branch July 1, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

Assignees

@uditagarwal97 uditagarwal97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uditagarwal97 @aelovikov-intel