-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Add MAC address support for interface retrieval in NetworkAdapt… #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds MAC address support for filtering and retrieving network interfaces in the network adapter owner classes. The enhancement enables users to query network interfaces by MAC address across both base and ESXi-specific implementations.
Key changes:
- Extended API methods to accept a
mac_addressparameter for interface filtering - Updated filtering logic to support MAC address-based queries
- Added comprehensive test coverage and updated examples
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mfd_network_adapter/network_adapter_owner/base.py | Added MAC address parameter to core filtering methods and updated validation logic |
| mfd_network_adapter/network_adapter_owner/esxi.py | Extended ESXi-specific implementation with MAC address filtering support |
| tests/unit/test_mfd_network_adapter/test_network_adapter_owner/test_esxi_network_owner.py | Added test case for MAC address filtering and updated test data |
| examples/linux_owner_example.py | Added example demonstrating MAC address-based interface retrieval |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
We don't publish DEVs .whl. |
c33ef08 to
9640ca1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
9640ca1 to
13c5008
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f94da85 to
b2497a0
Compare
adrianlasota
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readme update :P
done
…erOwner Signed-off-by: Lasota, Adrian <[email protected]>
…orkAdapterOwner and ARP feature Signed-off-by: Lasota, Adrian <[email protected]>
b2497a0 to
8549e2f
Compare
This pull request adds support for filtering and retrieving network interfaces by MAC address in the network adapter owner classes, extends the relevant APIs, and updates tests and examples accordingly. The changes ensure that both the base and ESXi-specific implementations can now handle MAC address-based queries for network interfaces.
API and Filtering Enhancements:
mac_addressparameter to theget_interfaces,get_interface, and internal_filter_interfaces_infomethods in both the base and ESXi network adapter owner classes, enabling filtering of interfaces by MAC address. [1] [2] [3] [4] [5]_filter_interfaces_info(base and ESXi) to select interfaces matching the specified MAC address. [1] [2]Documentation and Typing:
mac_addressparameter and its usage. [1] [2] [3] [4] [5] [6] [7]Validation and Logging:
mac_addressparameter, ensuring correct combinations and improved traceability. [1] [2] [3]Testing and Examples:
vmnic9. [1] [2]