-
Notifications
You must be signed in to change notification settings - Fork 52
Add command for showing all class members, including inherited #1656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command for showing all class members, including inherited #1656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. The way the symbol-class icon displays colored in the editor's action bar looks a bit weird, but that's not in our control. I'm going to open a VS Code issue about it. Approving this PR.
|
Perhaps the changelog for this item should mention that the |
|
I will check to see if I can apply a color to that ThemeIcon. According to the docs the color is only used for TreeItems. |
|
When I write up the CHANGELOG I'll add a second line for that |
There is no way for me to change the color of the icon in the command definition, so I will merge this |
I think the CSS change in microsoft/vscode#170562 should probably have excluded the case where the codicons are used in |
* Add command for showing all class members, including inherited (intersystems-community#1656) * Copy Windows filesystem file correctly to isfs filesystem (intersystems-community#1658) * Allow opening low-code editors from read-only file systems (intersystems-community#1655) * Skip compilation of web app files that do not require it (intersystems-community#1660) * Lite Terminal shell integration improvements (intersystems-community#1654) * Enable Terminal Completion via Language Server (intersystems-community#1661) * Prepare 3.2.0 release (intersystems-community#1662) * auto bump version with release --------- Co-authored-by: Brett Saviano <[email protected]> Co-authored-by: John Murray <[email protected]> Co-authored-by: ProjectBot <[email protected]>

This PR fixes #1623. Adds a class icon button to the editor title bar when the editor contains a class. When clicked, a QuickPick appears with all members of that class, including inherited ones. Clicking on a member shows it in the editor.
I initially tried to implement this as a tree view, which prompted me to make some architectural improvements. I kept those in because I think they are worth including. I consolidated three three
onDidChangeActiveTextEditorhandlers to a single one, and I added the existing tree views to the array of disposables so their resources get cleaned up properly.