Fixes for revert/reset error and settingsUIReadOnlly related basicMode/remoteRepo #782
+24
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code would generate an error due to 'workspaceView' being undefined.
Previously despite basicMode being editable on the settings screen it would not save when settingsUIReadOnly was true. The fact that it is grouped on the settings screen with the already editable and savable gitUserName and gitUserEmail settings suggests that basicMode is intended to be set by users and the inability to do is an oversight.
…ly present in the request This may occur for example when settingsUIReadOnly is true where 'remoteRepo' is not user editable
isc-pbarton
approved these changes
Jun 2, 2025
isc-pbarton
added a commit
that referenced
this pull request
Jun 2, 2025
isc-pbarton
added a commit
that referenced
this pull request
Jun 2, 2025
Changelog for fixes in #782
This was referenced Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for the following: