[tanka] Enforce manual selection of cockroachdb image #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminPelletier
approved these changes
Aug 27, 2024
barroco
added a commit
that referenced
this pull request
Aug 29, 2024
…ling (#1080) Following #1077 and #1076, tanka manifests and helm chart values require the cockroachdb version to be explicitely input. This PR upgrades terraform tooling to explicitly set in examples (*.examples.tf) and CI (deploy/operations/ci/aws-1/terraform.tfvars) the cockcroach db version. Users who have previously set a configuration following the instructions will have to add the image version to their configuration. A note will be provided in the release note.
barroco
added a commit
that referenced
this pull request
Aug 30, 2024
As requested in #1070 in order to properly support indexes used by the DSS, this PR upgrades CockroachDB to version 24.1.3. A backward incompatibility impacting migrations has been addressed in #1079. Depends on #1077, #1076 and #1080 to properly upgrade the version. This PR includes: Upgrade of all CRDB image references from 21.2.7 to 24.1.3. Migration notes and references to CRDB documentation. Helm: Instructions on how to adjust CRDB Helm deployment instructions to map to our Helm chart practices Tanka: Manual upgrade Kubernetes steps number have been changed to 1. instead of incremented numbers to reflect editing practices of other documents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #1076, in order to facilitate the upgrades of cockroachdb, this PR removes the default cockroach db version from the tanka configuration and requires users to set it in their configurations.
Users who have previously set a configuration following the instructions will have to add the image version to their configuration. A note will be provided in the release notes.
In anticipation of the CockroachDB upgrade to 24.1.3 (#1075) and the DSS v17 release, the description is already taking it into account.
Successfully tested with #1080.