Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tanka] Enforce manual selection of cockroachdb image #1077

Merged
merged 2 commits into from
Aug 29, 2024
Merged

[tanka] Enforce manual selection of cockroachdb image #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7882fd4
[tanka] Enforce manual selection of cockroachdb image
barroco Aug 23, 2024
9e9dcd0
Adjust README
barroco Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions build/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,10 @@ a PR to that effect would be greatly appreciated.
detection functionality (currently an R&D project tracking an initial
draft of the upcoming ASTM standard).

1. `VAR_CRDB_DOCKER_IMAGE_NAME`: Docker image of cockroach db pods. Until
DSS v0.16, the recommended CockroachDB image name is `cockroachdb/cockroach:v21.2.7`.
From DSS v0.17, the recommended CockroachDB version is `cockroachdb/cockroach:v24.1.3`.

1. `VAR_CRDB_HOSTNAME_SUFFIX`: The domain name suffix shared by all of your
CockroachDB nodes. For instance, if your CRDB nodes were addressable at
`0.db.example.com`, `1.db.example.com`, and `2.db.example.com`, then
Expand Down
1 change: 1 addition & 0 deletions build/deploy/examples/minimum/main.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ local metadata = metadataBase {
single_cluster: false,
enableScd: false, // <-- This boolean value is VAR_ENABLE_SCD
cockroach+: {
image: 'VAR_CRDB_DOCKER_IMAGE_NAME',
hostnameSuffix: 'VAR_CRDB_HOSTNAME_SUFFIX',
locality: 'VAR_CRDB_LOCALITY',
nodeIPs: ['VAR_CRDB_NODE_IP1', 'VAR_CRDB_NODE_IP2', 'VAR_CRDB_NODE_IP3'],
Expand Down
2 changes: 1 addition & 1 deletion build/deploy/metadata_base.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
shouldInit: false, // Set this to true if you are starting a new cluster.
grpc_port: 26257,
http_port: 8080,
image: 'cockroachdb/cockroach:v21.2.7',
image: error 'must specify cockroach db image. Until DSS v0.16, the recommended CockroachDB image is `cockroachdb/cockroach:v21.2.7`. From DSS v0.17, the recommended CockroachDB image is cockroachdb/cockroach:v24.1.3. Example: cockroachdb/cockroach:v21.2.7',
nodeIPs: error 'must supply the per-node ip addresses as an array', // For AWS, this array should contain the allocation id of the elastic ips.
JoinExisting: [],
storageClass: 'standard',
Expand Down
Loading