Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing odometry reset events #1222

Open
matlabbe opened this issue Oct 16, 2024 · 0 comments
Open

Missing odometry reset events #1222

matlabbe opened this issue Oct 16, 2024 · 0 comments

Comments

@matlabbe
Copy link
Member

If some odometry topics are published faster than sensor data, we could miss reset events or large covariances. Note that this would not happen with the multi-threaded version (#1214) if the sensor rate is in sync with odometry rate (like when we use visual odometry or icp odometry).

I tested decoupling odometry to its own callback so we don't miss any messages, though it makes it harder to "wait for odom tropic" if we receive sensor data faster than odometry delay. The current message_filters approach already solve that. Another drawback was for rtabmap_viz when we want to synchronize odometry info topic with the same sensor data generating that odom (to correctly overlay detected features on same image they were generated). Again, the message_filters approach solves that already.

Similar to inter_odom callback, we could look in parallel with a dedicated callback to just detect those reset events and appropriately not miss any covariance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant