-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CUI #8384
Remove CUI #8384
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8384 +/- ##
==========================================
+ Coverage 84.57% 85.23% +0.66%
==========================================
Files 1199 1176 -23
Lines 54527 52524 -2003
Branches 2074 2074
==========================================
- Hits 46117 44771 -1346
+ Misses 7906 7247 -659
- Partials 504 506 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
That's a lot of code removed :) |
@SchrodingersGat not even all - just the parts I think that are safe. I will open PRs that port over all the test changes to 0.17.0 already to make the diff of modified files smaller in this changeset. Things like the middleware tests |
@SchrodingersGat this is ready for review and merge once 0.17.0 is done; there will be some smaller follow-ups probably (removing all ajax, removing some frontend dependencies in backend). Keeping this in this state to leave it review-able. |
@matmair please fix conflicts here :) |
@SchrodingersGat fixed |
@matmair should we remove the frontend URL prefix "platform" now? Or would you like to do that as a separate PR |
I would like to keep changes to PUI separate from this whole CUI removal |
|
What a milestone! Thanks for all the amazing effort on this one @matmair Obviously as this is a huge change, we will have a lot of follow up and potential triage here. Let's keep an eye on it . |
This PR removes CUI and adjacent helpers that are no longer required.
Part of the preparation for 1.0 as listed in the blog.
closes #5754