Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CUI #8384

Merged
merged 39 commits into from
Dec 17, 2024
Merged

Remove CUI #8384

merged 39 commits into from
Dec 17, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Oct 28, 2024

This PR removes CUI and adjacent helpers that are no longer required.

Part of the preparation for 1.0 as listed in the blog.

closes #5754

@matmair matmair added user interface Platform UI Related to the React based User Interface labels Oct 28, 2024
@matmair matmair added this to the 1.0.0 milestone Oct 28, 2024
@matmair matmair self-assigned this Oct 28, 2024
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit b6bf72b
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6760c61874daf20008f511ec

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.23%. Comparing base (5d23296) to head (b6bf72b).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8384      +/-   ##
==========================================
+ Coverage   84.57%   85.23%   +0.66%     
==========================================
  Files        1199     1176      -23     
  Lines       54527    52524    -2003     
  Branches     2074     2074              
==========================================
- Hits        46117    44771    -1346     
+ Misses       7906     7247     -659     
- Partials      504      506       +2     
Flag Coverage Δ
backend 86.92% <ø> (+0.87%) ⬆️
migrations 43.15% <ø> (+0.39%) ⬆️
pui 69.09% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat
Copy link
Member

That's a lot of code removed :)

@matmair
Copy link
Member Author

matmair commented Oct 28, 2024

@SchrodingersGat not even all - just the parts I think that are safe. I will open PRs that port over all the test changes to 0.17.0 already to make the diff of modified files smaller in this changeset. Things like the middleware tests

@matmair matmair mentioned this pull request Dec 5, 2024
6 tasks
@matmair matmair closed this Dec 9, 2024
@matmair matmair reopened this Dec 9, 2024
@matmair matmair marked this pull request as ready for review December 9, 2024 00:29
@matmair
Copy link
Member Author

matmair commented Dec 9, 2024

@SchrodingersGat this is ready for review and merge once 0.17.0 is done; there will be some smaller follow-ups probably (removing all ajax, removing some frontend dependencies in backend). Keeping this in this state to leave it review-able.

@matmair matmair changed the title After 0.17.0: Remove CUI Remove CUI Dec 16, 2024
@SchrodingersGat
Copy link
Member

@matmair please fix conflicts here :)

@matmair
Copy link
Member Author

matmair commented Dec 16, 2024

@SchrodingersGat fixed

@SchrodingersGat
Copy link
Member

@matmair should we remove the frontend URL prefix "platform" now? Or would you like to do that as a separate PR

@matmair
Copy link
Member Author

matmair commented Dec 17, 2024

I would like to keep changes to PUI separate from this whole CUI removal

@matmair
Copy link
Member Author

matmair commented Dec 17, 2024

+ We need to consider the migration story with old CUI links

@SchrodingersGat
Copy link
Member

What a milestone! Thanks for all the amazing effort on this one @matmair

Obviously as this is a huge change, we will have a lot of follow up and potential triage here. Let's keep an eye on it .

@SchrodingersGat SchrodingersGat merged commit 24f433c into inventree:master Dec 17, 2024
28 checks passed
@SchrodingersGat SchrodingersGat deleted the pui-only branch December 17, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-run Always do a full QC CI run Platform UI Related to the React based User Interface
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[PUI] Remove custom themes
2 participants