Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove django-import-export #8685

Merged

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Dec 17, 2024

This can now be replaced entirely by the new import / export framework which uses the DRF API.

TODO

@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature breaking Indicates a major update or change which breaks compatibility refactor labels Dec 17, 2024
@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone Dec 17, 2024
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit d5dca17
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67696e396af5400008fb1691

Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm; might also enable removal of remaining Ajax (backend) functions.

@SchrodingersGat SchrodingersGat changed the title [1.0.0] remove django-import-export Remove django-import-export Dec 17, 2024
@SchrodingersGat SchrodingersGat added the dependency Relates to a project dependency label Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.16%. Comparing base (933330f) to head (d5dca17).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/part/bom.py 0.00% 2 Missing ⚠️
src/backend/InvenTree/InvenTree/views.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8685      +/-   ##
==========================================
- Coverage   85.24%   85.16%   -0.08%     
==========================================
  Files        1175     1170       -5     
  Lines       52444    51474     -970     
  Branches     2089     2087       -2     
==========================================
- Hits        44704    43839     -865     
+ Misses       7241     7135     -106     
- Partials      499      500       +1     
Flag Coverage Δ
backend 86.88% <95.00%> (-0.08%) ⬇️
migrations 43.05% <95.00%> (-0.14%) ⬇️
pui 69.09% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 71eb281 into inventree:master Dec 23, 2024
28 checks passed
@SchrodingersGat SchrodingersGat deleted the django-import-export-remove branch December 23, 2024 20:19
@matmair
Copy link
Member

matmair commented Dec 24, 2024

@SchrodingersGat there are quite a lot of now uncovered lines that seem only necesarry for the old import method - are they needed for #8686 or can we clean them up? https://app.codecov.io/gh/inventree/InvenTree/pull/8685/indirect-changes

@SchrodingersGat SchrodingersGat mentioned this pull request Dec 24, 2024
@SchrodingersGat
Copy link
Member Author

@matmair good point, I had missed some pruning - see #8756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Indicates a major update or change which breaks compatibility dependency Relates to a project dependency enhancement This is an suggested enhancement or new feature refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants