-
-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove django-import-export #8685
Remove django-import-export #8685
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm; might also enable removal of remaining Ajax (backend) functions.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8685 +/- ##
==========================================
- Coverage 85.24% 85.16% -0.08%
==========================================
Files 1175 1170 -5
Lines 52444 51474 -970
Branches 2089 2087 -2
==========================================
- Hits 44704 43839 -865
+ Misses 7241 7135 -106
- Partials 499 500 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…Gat/InvenTree into django-import-export-remove
@SchrodingersGat there are quite a lot of now uncovered lines that seem only necesarry for the old import method - are they needed for #8686 or can we clean them up? https://app.codecov.io/gh/inventree/InvenTree/pull/8685/indirect-changes |
This can now be replaced entirely by the new import / export framework which uses the DRF API.
TODO
Reimplement "bom export" in new framework- [1.0.0] Reimplement old BOM exporter #8686