Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #8756

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Cleanup #8756

wants to merge 3 commits into from

Conversation

SchrodingersGat
Copy link
Member

Ref: #8685 (comment)

Followup to #8685

@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone Dec 24, 2024
Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 4359870
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/676a0889b724870008eae924

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.93%. Comparing base (02e4306) to head (4359870).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8756      +/-   ##
==========================================
- Coverage   85.20%   84.93%   -0.27%     
==========================================
  Files        1172     1177       +5     
  Lines       51545    51728     +183     
  Branches     2089     2089              
==========================================
+ Hits        43918    43936      +18     
- Misses       7118     7283     +165     
  Partials      509      509              
Flag Coverage Δ
backend 87.38% <100.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matmair
Copy link
Member

matmair commented Dec 24, 2024

@SchrodingersGat this will require an API version bump as it removes a number of endpoints; maybe it makes more sense to include these in #8686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants