Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Barcode scan #8721

Closed

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Dec 19, 2024

image

Notes: I have tested this with a USB barcode reader, and it works pretty well

This is not intended as a full featureset for this quick-scan dialog. Rather it is intended to get the scan dialog working and fixed for 0.17.x branch

- Allow error message to be passed through via field definition
- Return error information to onFormError
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed enhancement This is an suggested enhancement or new feature barcode Barcode scanning and integration backport Apply this label to a PR to enable auto-backport action Platform UI Related to the React based User Interface backport-to-0.17.x Backport these changes to the 0.17.x branch labels Dec 19, 2024
@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone Dec 19, 2024
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit b45ba70
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6763b12d36e7560008fc8f1d
😎 Deploy Preview https://deploy-preview-8721--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SchrodingersGat SchrodingersGat mentioned this pull request Dec 19, 2024
@SchrodingersGat
Copy link
Member Author

SchrodingersGat commented Dec 19, 2024

Closing this, as I realise that this approach does not consider the "webcam" support at all. I have cherry picked some of the bug fixes I picked up along the way in #8722

@SchrodingersGat SchrodingersGat deleted the barcode-scan branch December 19, 2024 06:05
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 48.83721% with 22 lines in your changes missing coverage. Please review.

Project coverage is 85.14%. Comparing base (5379269) to head (b45ba70).

Files with missing lines Patch % Lines
src/frontend/src/components/buttons/ScanButton.tsx 40.90% 13 Missing ⚠️
src/frontend/src/components/forms/ApiForm.tsx 33.33% 4 Missing ⚠️
...frontend/src/components/forms/fields/TextField.tsx 50.00% 2 Missing ⚠️
src/frontend/src/hooks/UseForm.tsx 33.33% 1 Missing and 1 partial ⚠️
...rontend/src/components/forms/fields/TableField.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8721      +/-   ##
==========================================
- Coverage   85.25%   85.14%   -0.11%     
==========================================
  Files        1175     1174       -1     
  Lines       52432    52428       -4     
  Branches     2079     2091      +12     
==========================================
- Hits        44703    44642      -61     
- Misses       7228     7269      +41     
- Partials      501      517      +16     
Flag Coverage Δ
pui 68.49% <48.83%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Apply this label to a PR to enable auto-backport action backport-to-0.17.x Backport these changes to the 0.17.x branch barcode Barcode scanning and integration bug Identifies a bug which needs to be addressed enhancement This is an suggested enhancement or new feature Platform UI Related to the React based User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PUI] Use of external (USB) barcode scanner not possible in PUI
1 participant