-
-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PUI] Barcode scan #8721
[PUI] Barcode scan #8721
Conversation
- Allow error message to be passed through via field definition - Return error information to onFormError
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closing this, as I realise that this approach does not consider the "webcam" support at all. I have cherry picked some of the bug fixes I picked up along the way in #8722 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8721 +/- ##
==========================================
- Coverage 85.25% 85.14% -0.11%
==========================================
Files 1175 1174 -1
Lines 52432 52428 -4
Branches 2079 2091 +12
==========================================
- Hits 44703 44642 -61
- Misses 7228 7269 +41
- Partials 501 517 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Notes: I have tested this with a USB barcode reader, and it works pretty well
This is not intended as a full featureset for this quick-scan dialog. Rather it is intended to get the scan dialog working and fixed for 0.17.x branch