Forms fixes #8722
Merged
Forms fixes #8722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SchrodingersGat
commented
Dec 19, 2024
SchrodingersGat
commented
- Small forms fixes as discovered in [PUI] Barcode scan #8721
- Allow error message to be passed through via field definition - Return error information to onFormError
SchrodingersGat
added
bug
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8722 +/- ##
==========================================
+ Coverage 85.25% 85.30% +0.04%
==========================================
Files 1175 1174 -1
Lines 52432 52433 +1
Branches 2079 2087 +8
==========================================
+ Hits 44703 44727 +24
+ Misses 7228 7189 -39
- Partials 501 517 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matmair
approved these changes
Dec 19, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
* Refactor form fields - Allow error message to be passed through via field definition - Return error information to onFormError * Fix debounce issue for text fields * Fix for useForm hook * Badge fix - Fix badge rendering for SalesOrderShipment * Cleanup unit test (cherry picked from commit aabcf52)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
SchrodingersGat
added a commit
that referenced
this pull request
Dec 20, 2024
* Refactor form fields - Allow error message to be passed through via field definition - Return error information to onFormError * Fix debounce issue for text fields * Fix for useForm hook * Badge fix - Fix badge rendering for SalesOrderShipment * Cleanup unit test (cherry picked from commit aabcf52) Co-authored-by: Oliver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.