feat(ui, api): archive boards #6546
Conversation
maryhipp
requested review from
psychedelicious,
blessedcoolant,
hipsterusername and
brandonrising
as code owners
github-actions
bot
added
api
python
psychedelicious
force-pushed
the
maryhipp/archive-boards
branch
from
99e0293
to
e9e550f
Compare
There was a problem hiding this comment.
- I rebased this on main and fixed some conflicts. You can do
git pull --rebaseto sync locally. - I created a new component for the no board board context menu so we don't need to worry about whether or not there is a board.
Despite knowing that I can't archive the auto-add board, this immediately threw me for a loop. It took me 10 minutes reading through the code before I realized why I couldn't archive 😅 Doesn't feel right that I cannot archive the board I'm currently reviewing (when selected for auto-add).
I'm not sure it really does much, anyways. The auto-add board is baked into each graph, so you could queue up generations to a given board and then archive it. You could also delete the board after queuing, which I'd expect to result in runtime errors. Maybe it shouldn't be baked in.
We can think more on this as we work through the rest of the gallery changes if you want to get this PR in. Maybe we should revise the auto-add behaviour.
|
Agreed re auto-add interactions - I pushed up 7797a34 which just checks on archive or archive view changes if the currently selected auto-add board is visible. If its not, it changes auto-ad to the Uncategorized board. |
… them in the response
…ery settings to show/hide archived boards in list
Much easier to not need to handle the board being optional in the component.
…o-add board is not currently visible due to archived view
…exist Before this change, if you attempt to create an image that with a nonexistent board, we'd get an unhandled error when adding the image to a board. The record would be created, but file not, due to the structure of the code. With this change, we now log a warning if we have a problem adding the image to the board, but the record and file are still created. A future improvement would be to create a transaction for this part of the code, preventing some other situation that could result in only the record or only the file beings saved.
Looks like in the latest version of ruff, E721 was added or changed and now catches something it didn't before.
If the currently selected or auto-add board is archived or deleted, we should reset them. There are some edge cases taht weren't handled in the previous implementation. All handling of this logic is moved to the (renamed) listener.
psychedelicious
force-pushed
the
maryhipp/archive-boards
branch
from
f2dc8a3
to
822017b
Compare
|
Summary
Add the ability to archive boards, which essentially just hides them from view in the UI unless explicitly set to show them in settings. You also cannot use an archived board for auto-add functionality to avoid weirdness if its set and then archived boards are hidden.
This does add a new column to the database.
Related Issues / Discussions
Closes #3942
QA Instructions
Right-click on a board to archive it.
Toggle "Show archived boards" in gallery settings
Right-click on an archived board to unarchive it.
Merge Plan
Checklist