Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui, api): archive boards #6546

Merged
merged 21 commits into from
Jun 28, 2024
Merged

feat(ui, api): archive boards #6546

merged 21 commits into from
Jun 28, 2024

Commits on Jun 27, 2024

  1. feat(api): ability to archive boards

    @maryhipp @psychedelicious
    maryhipp authored and psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    d5483a5 View commit details
    Browse the repository at this point in the history

  2. feat(api): add archived query param to board list endpoint to include… 

    … them in the response
    @maryhipp @psychedelicious
    maryhipp authored and psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    02a4f55 View commit details
    Browse the repository at this point in the history

  3. cleanup

    @maryhipp @psychedelicious
    maryhipp authored and psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    dd25dda View commit details
    Browse the repository at this point in the history

  4. feat(ui): add ability to archive/unarchive boards, add toggle to gall… 

    …ery settings to show/hide archived boards in list
    @psychedelicious
    Mary Hipp authored and psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    87ba018 View commit details
    Browse the repository at this point in the history

  5. feat(ui): make archiving and auto-add mutually exclusive

    @psychedelicious
    Mary Hipp authored and psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    0d5c4ab View commit details
    Browse the repository at this point in the history

  6. lint fix

    @psychedelicious
    Mary Hipp authored and psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a5be10e View commit details
    Browse the repository at this point in the history

  7. ruff format

    @maryhipp @psychedelicious
    maryhipp authored and psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    958b365 View commit details
    Browse the repository at this point in the history

  8. fix tsc errors

    @psychedelicious
    Mary Hipp authored and psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    ccf8cad View commit details
    Browse the repository at this point in the history

  9. tidy(ui): archived icon component

    @psychedelicious
    psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    2d4edd3 View commit details
    Browse the repository at this point in the history

  10. feat(ui): separate context menu for no board board 

    Much easier to not need to handle the board being optional in the component.
    @psychedelicious
    psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    104a858 View commit details
    Browse the repository at this point in the history

  11. (ui) allow auto-add on archived boards, reset to uncategorized if aut… 

    …o-add board is not currently visible due to archived view
    @psychedelicious
    Mary Hipp authored and psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    3c37bf3 View commit details
    Browse the repository at this point in the history

  12. (ui): update query param to include_archived, fix cache when archivin… 

    …g boards
    @psychedelicious
    Mary Hipp authored and psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    fd8692f View commit details
    Browse the repository at this point in the history

  13. (api) change query param to include_archived

    @maryhipp @psychedelicious
    maryhipp authored and psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    cd6e37b View commit details
    Browse the repository at this point in the history

  14. lint fix

    @psychedelicious
    Mary Hipp authored and psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a767939 View commit details
    Browse the repository at this point in the history

  15. fix(app): when creating image, skip adding to board if board doesn't … 

    …exist

Before this change, if you attempt to create an image that with a nonexistent board, we'd get an unhandled error when adding the image to a board. The record would be created, but file not, due to the structure of the code.

With this change, we now log a warning if we have a problem adding the image to the board, but the record and file are still created.

A future improvement would be to create a transaction for this part of the code, preventing some other situation that could result in only the record or only the file beings saved.
    @psychedelicious
    psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    7098042 View commit details
    Browse the repository at this point in the history

  16. chore: ruff E721 

    Looks like in the latest version of ruff, E721 was added or changed and now catches something it didn't before.
    @psychedelicious
    psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    7387be6 View commit details
    Browse the repository at this point in the history

  17. feat(app): BoardRecord.archived is a required field

    @psychedelicious
    psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    d18da0b View commit details
    Browse the repository at this point in the history

  18. chore(ui): typegen

    @psychedelicious
    psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    037b17e View commit details
    Browse the repository at this point in the history

  19. feat(ui): handle edge cases when archiving/deleting boards 

    If the currently selected or auto-add board is archived or deleted, we should reset them. There are some edge cases taht weren't handled in the previous implementation.

All handling of this logic is moved to the (renamed) listener.
    @psychedelicious
    psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    822017b View commit details
    Browse the repository at this point in the history

  20. tests: update test_bulk_download.py after addition of archived field

    @psychedelicious
    psychedelicious committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1cd36ec View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. chore: ruff

    @psychedelicious
    psychedelicious committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    4b7938c View commit details
    Browse the repository at this point in the history