Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): model select overflowing when model names are too long #6660

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix(ui): model select overflowing when model names are too long #6660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion invokeai/frontend/web/src/features/parameters/components/MainModel/ParamMainModelSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const ParamMainModelSelect = () => {
<FormLabel>{t('modelManager.model')}</FormLabel>
</InformationalPopover>
<Tooltip label={tooltipLabel}>
<Box w="full">
<Box w="full" minW={0}>
<Combobox
value={value}
placeholder={placeholder}
Expand Down
22 changes: 12 additions & 10 deletions ...eai/frontend/web/src/features/sdxl/components/SDXLRefiner/ParamSDXLRefinerModelSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Combobox, FormControl, FormLabel } from '@invoke-ai/ui-library';
import { Box, Combobox, FormControl, FormLabel } from '@invoke-ai/ui-library';
import { createMemoizedSelector } from 'app/store/createMemoizedSelector';
import { useAppDispatch, useAppSelector } from 'app/store/storeHooks';
import { InformationalPopover } from 'common/components/InformationalPopover/InformationalPopover';
Expand Down Expand Up @@ -37,18 +37,20 @@ const ParamSDXLRefinerModelSelect = () => {
optionsFilter,
});
return (
<FormControl isDisabled={!options.length} isInvalid={!options.length}>
<FormControl isDisabled={!options.length} isInvalid={!options.length} w="full">
<InformationalPopover feature="refinerModel">
<FormLabel>{t('sdxl.refinermodel')}</FormLabel>
</InformationalPopover>
<Combobox
value={value}
placeholder={placeholder}
options={options}
onChange={onChange}
noOptionsMessage={noOptionsMessage}
isClearable
/>
<Box w="full" minW={0}>
<Combobox
value={value}
placeholder={placeholder}
options={options}
onChange={onChange}
noOptionsMessage={noOptionsMessage}
isClearable
/>
</Box>
</FormControl>
);
};
Expand Down
2 changes: 1 addition & 1 deletion ...tures/settingsAccordions/components/RefinerSettingsAccordion/RefinerSettingsAccordion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const RefinerSettingsAccordionContent: React.FC = memo(() => {

return (
<FormControlGroup isDisabled={!isRefinerModelSelected}>
<Flex p={4} gap={4} flexDir="column">
<Flex p={4} gap={4} flexDir="column" minW={0}>
<ParamSDXLRefinerModelSelect />
<FormControlGroup formLabelProps={stepsScaleLabelProps} isDisabled={!isRefinerModelSelected}>
<ParamSDXLRefinerScheduler />
Expand Down
2 changes: 1 addition & 1 deletion ...tures/settingsAccordions/components/UpscaleSettingsAccordion/UpscaleSettingsAccordion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export const UpscaleSettingsAccordion = memo(() => {
<Flex flexDir="column" gap={4}>
<Flex gap={4}>
<UpscaleInitialImage />
<Flex direction="column" w="full" alignItems="center" gap={2}>
<Flex direction="column" w="full" alignItems="center" gap={2} minW={0}>
<ParamSpandrelModel />
<UpscaleScaleSlider />
</Flex>
Expand Down
Loading