Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): copied edges must have new ids set #6676

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

psychedelicious
Copy link
Collaborator

Summary

Problems this was causing:

  • Deleting an edge was a copy of another edge deletes both edges
  • Deleting a node that was a copy-with-edges of another node deletes its edges and it's original edges, leaving what I will call "ghost noodles" behind

Related Issues / Discussions

I think @JPPhoto had reported this recently but I can't find where that was.

QA Instructions

  • Load a workflow
  • Copy a node that has a few inputs
  • Ctrl + Shift + V to paste the node and its edges
  • Delete one of the new edges - before this would delete the OG edge too, after it should not
  • Delete the copied node - before this would delete the OG input edges & cause ghost noodles, after should not

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added the frontend PRs that change frontend files label Jul 25, 2024
@psychedelicious psychedelicious enabled auto-merge (rebase) July 25, 2024 18:52
Problems this was causing:
- Deleting an edge was a copy of another edge deletes both edges
- Deleting a node that was a copy-with-edges of another node deletes its edges and it's original edges, leaving what I will call "ghost noodles" behind
@psychedelicious psychedelicious merged commit bb876b8 into main Jul 25, 2024
14 checks passed
@psychedelicious psychedelicious deleted the psyche/fix/ui/nodes-copy-fix branch July 25, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants