fix(ui): edge case where entity isn't visible until interacting with canvas #7099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
…canvas To trigger the edge case: - Have an empty layer and non-empty layer - Select the non-empty layer - Refresh the page - Select to the empty layer without doing any other action - You may be unable to draw on the layer - Zoom in/out slightly - You can now draw on it The problem was not syncing visibility when a layer is selected, leaving the layer hidden. This indirectly disabled interactions. The fix is to listen for changes to the layer's selected status and sync visibility when that changes.
psychedelicious
force-pushed
the
psyche/fix/ui/visibility-edge-case
branch
from
cae59fe
to
888a124
Compare
hipsterusername
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To trigger the edge case:
The problem was not syncing visibility when a layer is selected, leaving the layer hidden. This indirectly disabled interactions.
The fix is to listen for changes to the layer's selected status and sync visibility when that changes.
Also extracted common layer intersection logic to a method.
Related Issues / Discussions
n/a
QA Instructions
n/a
Merge Plan
n/a
Checklist