Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): edge case where entity isn't visible until interacting with canvas #7099

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix(ui): edge case where entity isn't visible until interacting with canvas #7099

merged 2 commits into from
Oct 11, 2024

Commits on Oct 11, 2024

  1. fix(ui): edge case where entity isn't visible until interacting with … 

    …canvas

To trigger the edge case:
- Have an empty layer and non-empty layer
- Select the non-empty layer
- Refresh the page
- Select to the empty layer without doing any other action
- You may be unable to draw on the layer
- Zoom in/out slightly
- You can now draw on it

The problem was not syncing visibility when a layer is selected, leaving the layer hidden. This indirectly disabled interactions.

The fix is to listen for changes to the layer's selected status and sync visibility when that changes.
    @psychedelicious
    psychedelicious committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    f860e33 View commit details
    Browse the repository at this point in the history

  2. tidy(ui): consistent naming for selector builder util

    @psychedelicious
    psychedelicious committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    888a124 View commit details
    Browse the repository at this point in the history