-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(ui): gallery / image perf #7101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves render perf for the image component by 10-20%.
Image elements register their target ref in a map, which is used to look up the image that was clicked on. Substantial perf improvement.
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
October 11, 2024 11:30
Oh this is smooooth. |
hipsterusername
approved these changes
Oct 11, 2024
maryhipp
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The gallery was getting very slow.
On
main
, on FF in dev mode, after loading 2 pages of the gallery so the images are cached, switching between them took ~105ms across 7 renders.With the changes in this PR, that's down to ~55ms across 3 renders.
This translates to the initial load of gallery pages and switching tabs in the app. Feels way better.
Specific changes:
IAIDndImage
&GalleryImage
(rendering components, calling hooks) until it's actually needed. We were spending a lot of time doing calculations or renders for things would likely never be used.Tested on FF, Safari, Chrome and iOS Safari. Makes a really big difference on iOS.
Related Issues / Discussions
n/a
QA Instructions
Poke around the gallery. Should feel snappier.
Merge Plan
n/a
Checklist