Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(ui): gallery / image perf #7101

Merged
merged 12 commits into from
Oct 11, 2024
Merged

perf(ui): gallery / image perf #7101

merged 12 commits into from
Oct 11, 2024

Commits on Oct 11, 2024

  1. feat(ui): use singleton context menu 

    This improves render perf for the image component by 10-20%.
    @psychedelicious
    psychedelicious committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    fb4ca3f View commit details
    Browse the repository at this point in the history

  2. perf(ui): do not call upload hook unless upload is needed

    @psychedelicious
    psychedelicious committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    901c357 View commit details
    Browse the repository at this point in the history

  3. perf(ui): remove extraneous useCallbacks

    @psychedelicious
    psychedelicious committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1557a2d View commit details
    Browse the repository at this point in the history

  4. perf(ui): remove another extraneous useCallback

    @psychedelicious
    psychedelicious committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e809616 View commit details
    Browse the repository at this point in the history

  5. perf(ui): memoize gallery page buttons

    @psychedelicious
    psychedelicious committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    3c6515f View commit details
    Browse the repository at this point in the history

  6. perf(ui): use single event for all image context menus 

    Image elements register their target ref in a map, which is used to look up the image that was clicked on. Substantial perf improvement.
    @psychedelicious
    psychedelicious committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    dadb7b1 View commit details
    Browse the repository at this point in the history

  7. perf(ui): properly memoize gallery image icon components

    @psychedelicious
    psychedelicious committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b6c1f43 View commit details
    Browse the repository at this point in the history

  8. tidy(ui): remove extraneous prop extraction

    @psychedelicious
    psychedelicious committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    606c478 View commit details
    Browse the repository at this point in the history

  9. perf(ui): efficient gallery image hover state

    @psychedelicious
    psychedelicious committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    02e4a2b View commit details
    Browse the repository at this point in the history

  10. fix(ui): safari doesn't have find on iterators

    @psychedelicious
    psychedelicious committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    8d2d7b3 View commit details
    Browse the repository at this point in the history

  11. docs(ui): add comments to ImageContextMenu

    @psychedelicious
    psychedelicious committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0269c2d View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into psyche/perf/ui/image-component

    @maryhipp
    maryhipp authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    c01d38b View commit details
    Browse the repository at this point in the history