Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): canvas auto mask followups 1 #7168

Merged
merged 6 commits into from
Oct 23, 2024
Merged

feat(ui): canvas auto mask followups 1 #7168

merged 6 commits into from
Oct 23, 2024

Conversation

psychedelicious
Copy link
Collaborator

Summary

  • Fix an issue where deleting the last point didn't reset the mask
  • Only subscribe listeners when actually segmenting (filter module gets same treatment)
  • Clean up abort controllers more thoroughly (filter module gets same treatment)
  • Update comments throughout SAM module

Related Issues / Discussions

n/a

QA Instructions

n/a

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Documentation added / updated (if applicable)

@psychedelicious
fix(ui): when last SAM point is deleted, reset ephemeral state
1442e3c
@psychedelicious
feat(ui): ensure abort controllers are cleaned up
d84095b
@psychedelicious
docs(ui): add comments to CanvasSegmentAnythingModule
6590d08
@psychedelicious
feat(ui): only subscribe listeners when segmenting
9513999 
Realized we are doing a lot of event listening even when segmenting is not occuring. I don't think this will have a meaningful performance impact, but it makes sense to remove these listeners when not in use.
@psychedelicious
feat(ui): abort controller in SAM module when destroying
9d7ede7
@psychedelicious
feat(ui): improve subs and cleanup in filterer module
919821c 
- Subscribe when starting the filterer
- Remember to abort the abortcontroller when destroying
- Unsubscribe when destroying
@github-actions github-actions bot added the frontend PRs that change frontend files label Oct 23, 2024
@hipsterusername hipsterusername merged commit 3583d03 into main Oct 23, 2024
14 checks passed
@hipsterusername hipsterusername deleted the psyche/feat/ui/canvas-auto-mask-followups-1 branch October 23, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psychedelicious @hipsterusername