Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): canvas auto mask followups 1 #7168

Merged
merged 6 commits into from
Oct 23, 2024
Merged

feat(ui): canvas auto mask followups 1 #7168

merged 6 commits into from
Oct 23, 2024

Commits on Oct 23, 2024

  1. fix(ui): when last SAM point is deleted, reset ephemeral state

    @psychedelicious
    psychedelicious committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1442e3c View commit details
    Browse the repository at this point in the history

  2. feat(ui): ensure abort controllers are cleaned up

    @psychedelicious
    psychedelicious committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d84095b View commit details
    Browse the repository at this point in the history

  3. docs(ui): add comments to CanvasSegmentAnythingModule

    @psychedelicious
    psychedelicious committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    6590d08 View commit details
    Browse the repository at this point in the history

  4. feat(ui): only subscribe listeners when segmenting 

    Realized we are doing a lot of event listening even when segmenting is not occuring. I don't think this will have a meaningful performance impact, but it makes sense to remove these listeners when not in use.
    @psychedelicious
    psychedelicious committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9513999 View commit details
    Browse the repository at this point in the history

  5. feat(ui): abort controller in SAM module when destroying

    @psychedelicious
    psychedelicious committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9d7ede7 View commit details
    Browse the repository at this point in the history

  6. feat(ui): improve subs and cleanup in filterer module 

    - Subscribe when starting the filterer
- Remember to abort the abortcontroller when destroying
- Unsubscribe when destroying
    @psychedelicious
    psychedelicious committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    919821c View commit details
    Browse the repository at this point in the history