Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Compatibility #50

Merged
merged 8 commits into from
Feb 28, 2025
Merged

Windows Compatibility #50

merged 8 commits into from
Feb 28, 2025

Conversation

arilieb
Copy link
Contributor

@arilieb arilieb commented Feb 27, 2025

  • Changed pathing to be OS agnostic
  • Skipped sys logging on Windows
  • Implemented conditional hosts:
  • 0.0.0.0 on MacOS and Linux
  • 127.0.0.1 on Windows
  • Binding to 0.0.0.0 is designed to listen on all interfaces, including 127.0.0.1, but stricter firewall settings on Windows can sometimes filter local loopback traffic when accessed via 0.0.0.0. In these cases, explicitly using 127.0.0.1 ensures that local connections are reliably routed without interference from system-wide network policies.
  • Implemented conditional serialing:
  • os library on MacOS and Linux
  • msvcrt library on Windows
  • Conditionally skip uxd tests on Windows

looks like did not run test after changing as name default is main not beta
@kentbull
Copy link
Contributor

This is cool, @arilieb, adding Windows support. Nice work.

…ame for Windows. Fixed test_filing to be fully Windows compatible.
@SmithSamuelM SmithSamuelM merged commit 9ef12b6 into ioflo:main Feb 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants