Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(testing): add caution for piercing shadow DOM #1373

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

christian-bromann
Copy link
Member

We have seen in Stencil that user are trying to use multiple >>> selectors within a single query which is afaik not possible. This patch adds docs to emphasize how to work around this limitation.

@christian-bromann christian-bromann requested a review from a team as a code owner March 13, 2024 01:59
@christian-bromann christian-bromann requested review from rwaskiewicz and tanner-reits and removed request for a team March 13, 2024 01:59
Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stencil-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 7:19pm

Copy link
Contributor

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 non blocker

docs/testing/stencil-testrunner/05-e2e-testing.md Outdated Show resolved Hide resolved
Copy link
Contributor

@rwaskiewicz rwaskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing some of this will be replaced with ionic-team/stencil#5481, but good to get the documentation in for older versions of Stencil 👍

@christian-bromann
Copy link
Member Author

I'm guessing some of this will be replaced with ionic-team/stencil#5481

Giving the limitations from the piercing approach using multiple >>> in one query I would advise this approach over the one suggested in #5481

@christian-bromann christian-bromann merged commit b998941 into main Mar 20, 2024
5 checks passed
@christian-bromann christian-bromann deleted the cb/caution-note-on-piercing branch March 20, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants