Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependabot for GHA and linkchecker #43

Merged
merged 14 commits into from
Nov 20, 2024

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Mar 21, 2024

Check for dead links and update the GitHub Actions. Should help catch issues like #41 early.

@ocefpaf ocefpaf marked this pull request as ready for review March 28, 2024 15:51
@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 28, 2024

@MathewBiddle
Copy link
Contributor

mmi links should go to https://mmisw.org/ont#/org/ioos

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 12, 2024

mmi links should go to https://mmisw.org/ont#/org/ioos

Thanks @MathewBiddle!. All links are fixed and the PR is passing now!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did these images get moved?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory they are in the wrong place for the link. However, jekyll may point to another folder and maybe this will break them. I need to check that...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a local build things seems to be OK (that table is one of the images I moved):

Screenshot from 2024-05-06 16-40-07

@MathewBiddle
Copy link
Contributor

I don't see dependabot in here. Was that intentional?

@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 20, 2024

I don't see dependabot in here. Was that intentional?

It was added in a future PR, #44, and I rebased this one making it "disappeaer" here. But it is already in the repo.

Copy link
Contributor

@MathewBiddle MathewBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great addition

@MathewBiddle MathewBiddle merged commit 3f4c338 into ioos:gh-pages Nov 20, 2024
1 check passed
@ocefpaf ocefpaf deleted the link_checker branch November 20, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants