-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dependabot for GHA and linkchecker #43
Conversation
I believe I fixed or found replacements for most broken links except for:
Edit: in https://github.com/ioos/glider-dac/pull/259/files we used,
Implementing those changes here but we still don't have replacements for the first two. |
mmi links should go to https://mmisw.org/ont#/org/ioos |
Thanks @MathewBiddle!. All links are fixed and the PR is passing now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did these images get moved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory they are in the wrong place for the link. However, jekyll may point to another folder and maybe this will break them. I need to check that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see dependabot in here. Was that intentional? |
It was added in a future PR, #44, and I rebased this one making it "disappeaer" here. But it is already in the repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Great addition
Check for dead links and update the GitHub Actions. Should help catch issues like #41 early.